From 7e1ea2b71456341e6ba6e2183fdbd87b6cfdf7ee Mon Sep 17 00:00:00 2001 From: Andrew Strong Date: Sat, 14 Mar 2015 20:07:32 +1100 Subject: [PATCH] Simplify opus tagging options This rectifies Issue 133. --- abcde | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/abcde b/abcde index cfa901d..36304a0 100755 --- a/abcde +++ b/abcde @@ -1160,16 +1160,10 @@ do_encode () %local*%) case "$OPUSENCODERSYNTAX" in opusenc) - - if [ "$(eval echo ${COMMENT})" != "" ]; then - case "$COMMENT" in - *=*) ;; - *) COMMENT="COMMENT=$COMMENT" ;; - esac - fi # Tag the file at encode time, as it can't be done after encoding. if [ "$DOTAG" = "y" ]; then - $RUN_COMMAND nice $EFFECTIVE_NICE $OPUSENCODER $OPUSENCODEROPTS --artist "$TRACKARTIST" --album "$DALBUM" --title "$TRACKNAME" --genre "$CDGENRE" --date "$CDYEAR" --comment TRACKNUMBER="$1" ${COMMENT:+--comment "$COMMENT"} "$IN" "$OUT" + $RUN_COMMAND nice $EFFECTIVE_NICE $OPUSENCODER $OPUSENCODEROPTS --artist "$TRACKARTIST" --album "$DALBUM" --title "$TRACKNAME" \ + --genre "$CDGENRE" --date "$CDYEAR" --comment TRACKNUMBER="$1" ${COMMENT:+--comment COMMENT="$COMMENT"} "$IN" "$OUT" else $RUN_COMMAND nice $EFFECTIVE_NICE $OPUSENCODER $OPUSENCODEROPTS "$IN" "$OUT" fi -- 2.20.1