Steve McIntyre [Mon, 26 Feb 2018 18:09:41 +0000 (18:09 +0000)]
More wrapping and quoting of variables
Steve McIntyre [Mon, 26 Feb 2018 18:06:05 +0000 (18:06 +0000)]
Add more details about CD lookup interface files
Steve McIntyre [Mon, 26 Feb 2018 17:49:48 +0000 (17:49 +0000)]
Catch errors from abcde-musicbrainz-tool better
Steve McIntyre [Mon, 26 Feb 2018 17:49:24 +0000 (17:49 +0000)]
Recognise more existing Debian packages
Steve McIntyre [Mon, 26 Feb 2018 17:36:31 +0000 (17:36 +0000)]
Add cd-discid to the known Debian packages too
Steve McIntyre [Mon, 26 Feb 2018 17:36:14 +0000 (17:36 +0000)]
Better detection for Debian systems
Steve McIntyre [Mon, 26 Feb 2018 15:24:25 +0000 (15:24 +0000)]
Switch from $ABCDETEMPDIR to ${ABCDETEMPDIR} globally
Steve McIntyre [Mon, 26 Feb 2018 15:22:20 +0000 (15:22 +0000)]
Tweak text output
Steve McIntyre [Sun, 25 Feb 2018 23:14:16 +0000 (23:14 +0000)]
Redirect stderr on "which" calls to clear up error noise
on some systems. Closes Issue 56:
https://abcde.einval.com/bugzilla/show_bug.cgi?id=56
Steve McIntyre [Sun, 25 Feb 2018 23:00:40 +0000 (23:00 +0000)]
Better handling of file copying in the different cddb methods
Avoid errors - only try to copy files that exist
Steve McIntyre [Sun, 25 Feb 2018 22:58:10 +0000 (22:58 +0000)]
Remove duplicated entry in the GetOptions code
Steve McIntyre [Sun, 25 Feb 2018 00:27:31 +0000 (00:27 +0000)]
Don't add $CDDBHOST to the datasource file
It's the local machine name, not the remote cddb host. Not all that
useful!
Steve McIntyre [Sun, 25 Feb 2018 00:20:22 +0000 (00:20 +0000)]
Fix code handling $NUM_CDDB_MATCHES in do_cddb_read
The code here is in a sub-shell, so modifications to $NUM_CDDB_MATCHES
do not persist in the parent. Yay shell. Work around this.
Tom Samstag [Sat, 11 Feb 2017 19:30:27 +0000 (11:30 -0800)]
fix release year code
The fix for #30 implemented in
1f1d33c64206841195a196595ed48f78952c07e6
relies on the release-event-list node from MB containing a count
attribute. However in my testing, that isn't the case, and so the
release year is never populated. This change checks that the
release_event_list isn't undef before trying to get the events (the
cause of the exception in #30) but then doesn't rely on the count() of
the release_event_list.
Steve McIntyre [Wed, 21 Feb 2018 21:33:16 +0000 (21:33 +0000)]
Add more examples for filename munging in the example config file
Closes Issue 49: https://abcde.einval.com/bugzilla/show_bug.cgi?id=49
Steve McIntyre [Wed, 21 Feb 2018 21:26:20 +0000 (21:26 +0000)]
Update example config for cddb options
Steve McIntyre [Wed, 21 Feb 2018 21:20:45 +0000 (21:20 +0000)]
Fix abcde.mkcue() when handling the --wholedisk option.
Thanks to Nino Burini for the patch. Closes Issue 47 and maybe also
45:
https://abcde.einval.com/bugzilla/show_bug.cgi?id=47
https://abcde.einval.com/bugzilla/show_bug.cgi?id=45
Steve McIntyre [Wed, 21 Feb 2018 21:09:00 +0000 (21:09 +0000)]
Add mention of issue 42 for the cddb rework
Steve McIntyre [Wed, 21 Feb 2018 21:02:43 +0000 (21:02 +0000)]
Stop hard-coding terminal length as 24 in various places
It should be in the $LINES environment variable on a sane system. If
it's not set, then set it to 24 in case.
Steve McIntyre [Wed, 21 Feb 2018 20:57:23 +0000 (20:57 +0000)]
Fix Musicbrainz ID calculation in makeids()
Apply fix suggested by petecollins24@gmail.com; add PREGAP to LEADOUT
to correct Musicbrainz ID calculation. Hopefully closes Issue 54:
https://abcde.einval.com/bugzilla/show_bug.cgi?id=54
Steve McIntyre [Wed, 21 Feb 2018 20:35:07 +0000 (20:35 +0000)]
Fix missing word in comment
Steve McIntyre [Wed, 21 Feb 2018 20:34:54 +0000 (20:34 +0000)]
Fix indentation
Steve McIntyre [Wed, 21 Feb 2018 19:07:24 +0000 (19:07 +0000)]
Massive rework of CD lookup code to support multiple sources better
Thanks to Gabriel Rosenkoetter for his initial idea in this area, and
to Tomasz Goliński on irc for initial inspiration on how this should
work better.
There are now 3 different options for CD lookup: cddb, musicbrainz and
cdtext. They can all be listed in a comma-separated list for
CDDBMETHOD and the code will now call all of them in the sequence
listed. All the results will be combined into one list at the end for
the user to select, just like would have previously worked for one
source only.
Significant changes to the lookup code to make this happen:
* cdtext is now promoted to a first-class lookup option instead of
just a fallback
* We now *always* calculate the cddb-style discid and use that as our
unique reference in various places, even if only doing
musicbrainz. This makes things work more consistently.
* Checks for the contents of $CDDBMETHOD have all been updated to
cope with multiple entries
* Various variable names have been globally renamed to make things
more obvious: TRACKINFO->CDDBTRACKINFO, DISCID->CDDBDISCID etc.
* To help keep things separated, each lookup option has its own
temporary subdirectory under ABCDETEMPDIR. The number of matches is
kept globally in NUM_CDDB_MATCHES.
* For the cddb lookup code, merged together the three functions
do_cddbstat(), do_cddbquery() and do_cddbread() into one:
do_cddb_read(). The previous separation was pointless, as all three
were always called together in sequence anyway.
* Removed the CDDBLASTMETHOD handling as it's now obsolete. Instead,
once all the desired lookup methods have been called we will create
an empty template if needed then.
Steve McIntyre [Wed, 21 Feb 2018 18:10:53 +0000 (18:10 +0000)]
Add support for storing musicbrainz lookups at chosen result numbers
Pre-requisite for the support for multiple lookup tools. Add the
"--start N" command line option to tell abcde-musicbrainz-tool to
start storing its results at cddbread.N instead of assuming
cddbread.1.
Steve McIntyre [Wed, 21 Feb 2018 18:08:58 +0000 (18:08 +0000)]
Initial effort to document abcde's inner workings
I've written up how things are stored as abcde does CD lookups, while
working on the support for running more than one for each CD.
Maybe more will follow... :-)
Andrew Strong [Sat, 2 Dec 2017 04:26:26 +0000 (15:26 +1100)]
Man pages: Add details of abcde's post_encode function
Thanks to Joe Harrington for pointing out this omission.
Andrew Strong [Fri, 1 Dec 2017 04:08:35 +0000 (15:08 +1100)]
Allow use of genre in embedalbumart function
Thanks to Joe Harrington for the bug report.
Andrew Strong [Fri, 28 Jul 2017 10:34:06 +0000 (20:34 +1000)]
Experimental support for embedding album art to ogg
The slightly tortuous technique drawn from 2 sources:
1. https://github.com/biapy/howto.biapy.com/blob/master/various/mussync-tools
2. https://github.com/acabal/scripts/blob/master/ogg-cover-art
Testing is strongly encouraged, perhaps the simplest way to test is with:
abcde -Q cddb -o ogg -B
Or the appropriate settings in an ~/.abcde.conf file.
Andrew Strong [Fri, 28 Jul 2017 01:44:17 +0000 (11:44 +1000)]
Fix embedding album art with single track encodes
Allow for embedding with do_embedalbumart() for single
track encodes when OUTPUTFORMAT and ONETRACKOUTPUTFORMAT
are different. Thanks to Ashley Gittins for the bug report.
This closes Issue 63:
https://abcde.einval.com/bugzilla/show_bug.cgi?id=63
Andrew Strong [Sat, 22 Jul 2017 05:12:02 +0000 (15:12 +1000)]
Update 'available formats' in FAQ
Andrew Strong [Fri, 14 Jul 2017 07:43:35 +0000 (17:43 +1000)]
Select CDDBMETHOD from the command line
Allow selection of either cddb or musicbrainz from the command line:
-Q Select CDDBMETHOD from the command line. Choice is cddb or musicbrainz.
Command line letters are fast running out but the 'Q' option quite neatly
stands for 'Query'!
Andrew Strong [Fri, 14 Jul 2017 07:18:18 +0000 (17:18 +1000)]
Makefile altered to reflect abcde 2.8.2
Andrew Strong [Fri, 14 Jul 2017 07:09:07 +0000 (17:09 +1000)]
Part 2 of 2: AIFF encoding for abcde
Documentations for the new AIFF encoding capabilities of abcde.
Andrew Strong [Fri, 14 Jul 2017 06:43:51 +0000 (16:43 +1000)]
Part 1 of 2: AIFF encoding for abcde
Support added for encoding with Audio Interchange File Format (AIFF).
Thanks to Massimo Villa for the feature request.
FFmpeg is required for the encoding, the container and suffix are
'aiff'. A sample ~/.abcde.conf file is available here:
http://www.andrews-corner.org/linux/abcde/abcde_lossless.html#aiff
Ville Skyttä [Sun, 25 Jun 2017 10:07:50 +0000 (13:07 +0300)]
Spelling fixes
Andrew Strong [Sun, 19 Mar 2017 06:11:47 +0000 (17:11 +1100)]
Use md5 rather than md5sum under MacOS
Under MacOS md5 is installed by default rather than md5sum,.
Thanks to JCount for the bug report and also the fix.
This solves Issue 59:
https://abcde.einval.com/bugzilla/show_bug.cgi?id=59.
Andrew Strong [Sun, 19 Feb 2017 04:28:34 +0000 (15:28 +1100)]
Allow album art embedding for WavPack files
This requires the utility wvtag which comes with WavPack 5.1.0
Andrew Strong [Sat, 4 Feb 2017 07:54:10 +0000 (18:54 +1100)]
Embed album art for mp3, flac and m4a
Allow for embedding of album art downloaded by the getalbumart fuction.
Currently this is available for flac (using metaflac), mp3 (using eyed3)
and m4a (using AtomicParsley). This can be invoked in 3 ways:
1. Use the commandline '-B' option (this will also call getalbumart)
2. Use the commandline '-a embedalbumart' option to add to list of actions
3. Use 'embedalbumart' in the 'ACTIONS' list in ~/.abcde.conf
Still needs more development but it is perfectly usable at the moment!
Andrew Strong [Wed, 1 Feb 2017 08:36:15 +0000 (19:36 +1100)]
Editing the abcde maintainers...
Taking myself from the list of maintainers
Matthias Andree [Wed, 1 Feb 2017 07:40:35 +0000 (18:40 +1100)]
Locale fixes, and optimization, for CD-TEXT lookup
Patch 2 of 2 to address the issue where abcde fails with accented
characters from CD-TEXT.
This addresses issue 52:
https://abcde.einval.com/bugzilla/show_bug.cgi?id=53
Thanks again to Matthias Andree <matthias.andree@gmx.de> for his
contributions to abcde!
Matthias Andree [Wed, 1 Feb 2017 07:31:04 +0000 (18:31 +1100)]
cddb-tool: force grep to read binaries as text
Patch 1 of 2 to address the issue where abcde fails with accented
characters from CD-TEXT.
Issue no. 53:
https://abcde.einval.com/bugzilla/show_bug.cgi?id=53
Andrew Strong [Tue, 24 Jan 2017 09:14:10 +0000 (20:14 +1100)]
Add documentation for dagrab options
Some documentation added for the aged CD ripper dagrab. Thanks
to Teika Kazura for the notification and suggested documentation.
This closes Issue 50: https://abcde.einval.com/bugzilla/show_bug.cgi?id=50
Andrew Strong [Tue, 24 Jan 2017 08:52:27 +0000 (19:52 +1100)]
Rebadge t0 abcde 2.8.2-UNRELEASED
Steve McIntyre [Wed, 18 Jan 2017 13:56:14 +0000 (13:56 +0000)]
Release abcde version 2.8.1
Steve McIntyre [Wed, 18 Jan 2017 11:04:31 +0000 (11:04 +0000)]
Add missing date in changelog file
Steve McIntyre [Wed, 18 Jan 2017 11:04:18 +0000 (11:04 +0000)]
Fix silly error introduced in abcde-musicbrainz-tool
when fixing bug 30. Thanks to Thomas Klausner for the
bug/patch. Closes Issue 52:
https://abcde.einval.com/bugzilla/show_bug.cgi?id=52
Steve McIntyre [Sat, 14 Jan 2017 17:28:47 +0000 (17:28 +0000)]
sync packaging changes from the Debian 2.8-1 release
Steve McIntyre [Sat, 14 Jan 2017 00:53:48 +0000 (00:53 +0000)]
Release abcde version 2.8
Steve McIntyre [Fri, 13 Jan 2017 00:59:53 +0000 (00:59 +0000)]
Switch default from "cddb" to "musicbrainz" for track lookup
Closes Debian Bug #842178
Steve McIntyre [Fri, 13 Jan 2017 00:34:15 +0000 (00:34 +0000)]
Add "-L" to default curl options, to follow redirects if needed
Closes Issue 40:
https://abcde.einval.com/bugzilla/show_bug.cgi?id=40
Thanks to Gabriel Rosenkoetter for the patch.
Steve McIntyre [Fri, 13 Jan 2017 00:25:38 +0000 (00:25 +0000)]
Add "-a" to lots of grep calls in case of "binary" looking data
e.g. non-ascii text in track titles!
Closes Issue 24:
https://abcde.einval.com/bugzilla/show_bug.cgi?id=24
Steve McIntyre [Fri, 13 Jan 2017 00:09:57 +0000 (00:09 +0000)]
Re-enable some commented out cdparanoia/debug code in do_discid.
Closes Issue 14:
https://abcde.einval.com/bugzilla/show_bug.cgi?id=14
Can't find any reason why this code was ever disabled...!
Steve McIntyre [Thu, 12 Jan 2017 16:10:23 +0000 (16:10 +0000)]
Tweak the fix in musicbrainz for handling sketchy returned data some more
Hopefully closes Issue 30:
https://abcde.einval.com/bugzilla/show_bug.cgi?id=30
Steve McIntyre [Thu, 12 Jan 2017 16:09:20 +0000 (16:09 +0000)]
Fix up handling of the first few sectors
when reading from a whole-CD flac file or using cdparanoia in
one-track mode. Thanks to Matthias König for the patch. Closes Issue
44: https://abcde.einval.com/bugzilla/show_bug.cgi?id=44
Steve McIntyre [Wed, 11 Jan 2017 01:09:09 +0000 (01:09 +0000)]
Add Recommends on glyrc and imagemagick in Debian packaging
Closes Debian Bug #827626
Andrew Strong [Fri, 6 Jan 2017 23:20:09 +0000 (10:20 +1100)]
Minor changes to man pages for AAC
Andrew Strong [Fri, 6 Jan 2017 23:12:17 +0000 (10:12 +1100)]
AAC cleanup for the included abcde.conf file
Several small edits related to AAC encoding in preparation
for the upcoming release.
Andrew Strong [Wed, 4 Jan 2017 03:52:50 +0000 (14:52 +1100)]
Show built-in FLACGAINOPTS in the sample .abcde.conf file
Andrew Strong [Sun, 25 Dec 2016 09:51:10 +0000 (20:51 +1100)]
Extra variable for the albun art embedding example
Thanks to Pastor Benjamin Steenbock for suggesting the addition
of a YEAR variable to the given example for embedding downloaded
album art.
Andrew Strong [Tue, 6 Dec 2016 09:42:36 +0000 (20:42 +1100)]
abcde.conf: make fdkaac the default AAC encoder
Andrew Strong [Tue, 6 Dec 2016 07:06:47 +0000 (18:06 +1100)]
Remove bladeenc from Debian 'depends'...
Andrew Strong [Tue, 6 Dec 2016 07:01:58 +0000 (18:01 +1100)]
Make fdkaac default for m4a encoding
Encoding with the previous default encoder: faac remains possible
by specifying:
AACENCODERSYNTAX=faac
in the ~/.abcde.conf file. Best not to though as fdkaac will
produce hugely better sound quality...
Andrew Strong [Wed, 21 Sep 2016 00:44:04 +0000 (10:44 +1000)]
Documentation for multiple CD lookup services.
Steve McIntyre [Tue, 20 Sep 2016 23:54:51 +0000 (00:54 +0100)]
Add support for trying multiple CD lookup services in order.
Thanks to Gabriel Rosenkoetter for the patch. Closes Issue 42:
https://abcde.einval.com/bugzilla/show_bug.cgi?id=42
Steve McIntyre [Tue, 20 Sep 2016 23:46:22 +0000 (00:46 +0100)]
Start development for 2.8 - some biggish changes coming, maybe
Andrew Strong [Fri, 5 Aug 2016 02:25:59 +0000 (12:25 +1000)]
Bump the sample abcde.conf file to 2.7.3
Andrew Strong [Fri, 5 Aug 2016 02:12:59 +0000 (12:12 +1000)]
Expand munge* functions
Split user-definable mungefilename function into mungetrackname,
mungeartistname, and mungealbumname, each of which default to
mungefilename. Thanks to Gerald Turner for the patch and
enhancement request.
This closes Issue 39:
https://abcde.einval.com/bugzilla/show_bug.cgi?id=39
Andrew Strong [Tue, 2 Aug 2016 08:20:37 +0000 (18:20 +1000)]
FAQs: Clarify the exit from multi-result CDDB search.
Thanks to Shantiq and mc4man from the Ubuntu Forums for the
request for this clarification.
Andrew Strong [Tue, 19 Jul 2016 08:23:39 +0000 (18:23 +1000)]
Allow multiple output formats when aac fallback is triggered.
Thanks to Birk Bremer for the bug report. This closes Issue 35:
https://abcde.einval.com/bugzilla/show_bug.cgi?id=35
Andrew Strong [Tue, 21 Jun 2016 08:45:25 +0000 (18:45 +1000)]
Add forgotten release date for 2.7.2 Changelog
Andrew Strong [Tue, 21 Jun 2016 08:38:07 +0000 (18:38 +1000)]
Fix for some erroneous error and status logging.
Thanks to Christian Wasem for the bug report and fix.
This closes Issue 32:
https://abcde.einval.com/bugzilla/show_bug.cgi?id=32
Andrew Strong [Mon, 23 May 2016 10:38:17 +0000 (20:38 +1000)]
Name the development version: 2.7.3-UNRELEASED
Steve McIntyre [Mon, 16 May 2016 14:55:14 +0000 (15:55 +0100)]
Misc FAQ updates
Steve McIntyre [Mon, 16 May 2016 14:46:32 +0000 (15:46 +0100)]
update footer emails to match current maintainers
Steve McIntyre [Wed, 13 Apr 2016 23:16:24 +0000 (00:16 +0100)]
Update current maintainer list in the README
Steve McIntyre [Wed, 13 Apr 2016 23:16:05 +0000 (00:16 +0100)]
s/http/https/ for various URLs
Steve McIntyre [Wed, 13 Apr 2016 23:07:13 +0000 (00:07 +0100)]
Updated debian files to match the 2.7.2-2 release
Andrew Strong [Wed, 6 Apr 2016 08:47:56 +0000 (18:47 +1000)]
Release version 2.7.2
Andrew Strong [Sat, 26 Mar 2016 23:42:47 +0000 (10:42 +1100)]
README adjusted for 2.7.2
Steve McIntyre [Sun, 21 Feb 2016 17:22:12 +0000 (17:22 +0000)]
Bugfix for year support in musicbrainz interface
When using musicbrainz, don't assume that there will be release events
attached to a particular CD release.
Ville Skyttä [Tue, 5 Jan 2016 22:18:25 +0000 (00:18 +0200)]
Man page syntax fixes
Ville Skyttä [Sat, 2 Jan 2016 12:12:30 +0000 (14:12 +0200)]
grep cddb data with -a for better behavior with charset issues
For example, grepping ISO-8859-1 data from cd-text in a UTF-8
environment without -a gives "Binary file ... matches".
Ville Skyttä [Sat, 2 Jan 2016 12:07:16 +0000 (14:07 +0200)]
Don't discard all previous cddbdata if a sed on cd-text data errors out
Ville Skyttä [Sat, 2 Jan 2016 11:45:27 +0000 (13:45 +0200)]
Another indentation fix
Ville Skyttä [Sat, 2 Jan 2016 11:30:09 +0000 (13:30 +0200)]
Indentation fixes
Andrew Strong [Fri, 1 Jan 2016 05:42:49 +0000 (16:42 +1100)]
Support usage of Matroska container (mka)
Support is added for output to the Matroska container (mka). The
encoder/muxer is FFmpeg (or avconv). Typical ~/.abcde.conf file
syntax would be:
MKAENCODERSYNTAX=ffmpeg
FFMPEG=ffmpeg
FFMPEGENCOPTS="-c:a ac3 -b:a 448k"
OUTPUTTYPE="mka"
Thanks to Shantiq and Fakeoutdoorsman of the Ubuntu Forums
for the idea!
Andrew Strong [Fri, 25 Dec 2015 21:52:05 +0000 (08:52 +1100)]
Changelog updates
Christopher Zimmermann [Wed, 23 Dec 2015 09:58:33 +0000 (10:58 +0100)]
Add id3tag mp3 tagger
this is the only tagger available on OpenBSD.
Andrew Strong [Thu, 17 Dec 2015 01:32:19 +0000 (12:32 +1100)]
Allow for cddb response 500
Thanks again to Von Welch for the bug report and patch.
This closes Issue 26:
http://abcde.einval.com/bugzilla/show_bug.cgi?id=26
Andrew Strong [Wed, 16 Dec 2015 01:44:13 +0000 (12:44 +1100)]
Add missing dates to changelog.
Andrew Strong [Tue, 15 Dec 2015 23:33:35 +0000 (10:33 +1100)]
Fix for 'expansion of $REDIR' bug on MacOSX.
Thanks to Von Welch for the bug report and testing of the fix.
This closes Issue 22:
http://abcde.einval.com/bugzilla/show_bug.cgi?id=22
Andrew Strong [Sat, 12 Dec 2015 04:59:38 +0000 (15:59 +1100)]
makefile fix: Install the sample abcde.conf file to /etc
Makefile adjusted to allow the sample abcde.conf file to be
installed by default to /etc rather than $(prefix)/etc.
Thanks to Volker Schmidt from archlinux for the bug report:
https://bugs.archlinux.org/task/46671
As it stands abcde looks for a conf file in 2 places:
1. /etc/abcde.conf
2. $HOME/.abcde.conf
and this is probably enough for most users...
Andrew Strong [Fri, 11 Dec 2015 22:57:39 +0000 (09:57 +1100)]
Fix to allow getalbumart to place image correctly for ONETRACK.
Thanks to Nino Burini for the bug report and also the fix. This
closes Issue 25:
http://abcde.einval.com/bugzilla/show_bug.cgi?id=25
Steve McIntyre [Mon, 2 Nov 2015 19:15:55 +0000 (19:15 +0000)]
Tweak debian/rules to match the Makefile changes
Steve McIntyre [Mon, 2 Nov 2015 18:53:56 +0000 (18:53 +0000)]
Update the Homepage in debian/control
Steve McIntyre [Mon, 2 Nov 2015 18:45:54 +0000 (18:45 +0000)]
Update debian/changelog for 2.7.1
Steve McIntyre [Mon, 2 Nov 2015 18:43:21 +0000 (18:43 +0000)]
Update the debian/watch file to match our new home
Andrew Strong [Sun, 4 Oct 2015 09:45:14 +0000 (20:45 +1100)]
Start development for abcde 2.7.2
Andrew Strong [Sun, 4 Oct 2015 09:30:28 +0000 (20:30 +1100)]
Release version 2.7.1
Andrew Strong [Sat, 3 Oct 2015 22:51:59 +0000 (09:51 +1100)]
Additional notes for mp2 encoding with FFmpeg...