* Fix aac tagging. (Closes issue 7).
authorSteve McIntyre <steve@einval.com>
Thu, 19 Apr 2012 14:10:02 +0000 (14:10 +0000)
committerSteve McIntyre <steve@einval.com>
Thu, 19 Apr 2012 14:10:02 +0000 (14:10 +0000)
    Thanks to Andrew Strong for forwarding the patch.

abcde
changelog

diff --git a/abcde b/abcde
index 6281693..e1123a5 100755 (executable)
--- a/abcde
+++ b/abcde
@@ -1151,8 +1151,8 @@ do_encode ()
                                $RUN_COMMAND nice $EFFECTIVE_NICE $MPPENCODER $MPPENCODEROPTS --artist "$TRACKARTIST" --album "$DALBUM" --title "$TRACKNAME" --track "$1" --genre "$CDGENRE" --year "$CDYEAR" --comment "$COMMENT" "$IN" "$OUT"
                                ;;
                        m4a)
-                               # Quick hack to avoid tagging Ogg/Speex, since there is no other way to tag than inline tagging
-                               if [ "$DOTAG" = "y" ]; then
+                               # Tag the file at encode time, as it can't be done after encoding.
+                               if [ "$DOTAG" = "y" ]; then
                                        $RUN_COMMAND nice $EFFECTIVE_NICE $AACENCODER $AACENCODEROPTS --artist "$TRACKARTIST" --album "$DALBUM" --title "$TRACKNAME" --track "$1" --genre "$CDGENRE" --year "$CDYEAR" --comment "$COMMENT" -o "$OUT" "$IN"
                                        
                                else
index 4faf31d..45846cf 100644 (file)
--- a/changelog
+++ b/changelog
@@ -10,6 +10,8 @@ abcde 2.5.1 UNRELEASED
       Closes: #669141
   * Fix speex tagging. (Closes issue 19).
     Thanks to vskytta for the patch.
+  * Fix aac tagging. (Closes issue 7).
+    Thanks to Andrew Strong for forwarding the patch.
 
   [ Colin Tuckley ]
   * replace deprecated egrep with grep -E (Closes issue 24).