CDDBTRACKNUM=$(expr $UTRACKNUM - 1)
do_getcddbinfo TRACKNAME
splitvarious
- TRACKFILE=$(mungefilename "$TRACKNAME")
- ARTISTFILE=$(mungefilename "$TRACKARTIST")
- ALBUMFILE=$(mungefilename "$DALBUM")
+ TRACKFILE="$(mungefilename "$TRACKNAME")"
+ ARTISTFILE="$(mungefilename "$TRACKARTIST")"
+ ALBUMFILE="$(mungefilename "$DALBUM")"
do_gettracknum
if [ "$VARIOUSARTISTS" = "y" ]; then
OUTPUTFILE=$(eval echo $VAOUTPUTFORMAT)
if [ "$VARIOUSARTISTS" = "y" ] && [ ! "$ONETRACK" = "y" ]; then
case "$VARIOUSARTISTSTYLE" in
forward)
- DTITLEARTIST=$(echo "$TRACKNAME" | sed 's- / -~-g')
- TRACKARTIST=$(echo "$DTITLEARTIST" | cut -f1 -d~)
- TRACKNAME=$(echo "$DTITLEARTIST" | cut -f2 -d~)
+ DTITLEARTIST="$(echo "$TRACKNAME" | sed 's- / -~-g')"
+ TRACKARTIST="$(echo "$DTITLEARTIST" | cut -f1 -d~)"
+ TRACKNAME="$(echo "$DTITLEARTIST" | cut -f2 -d~)"
;;
forward-dash)
- DTITLEARTIST=$(echo "$TRACKNAME" | sed 's, - ,~,g')
- TRACKARTIST=$(echo "$DTITLEARTIST" | cut -f1 -d~)
- TRACKNAME=$(echo "$DTITLEARTIST" | cut -f2 -d~)
+ DTITLEARTIST="$(echo "$TRACKNAME" | sed 's, - ,~,g')"
+ TRACKARTIST="$(echo "$DTITLEARTIST" | cut -f1 -d~)"
+ TRACKNAME="$(echo "$DTITLEARTIST" | cut -f2 -d~)"
;;
reverse)
- DTITLEARTIST=$(echo "$TRACKNAME" | sed 's- / -~-g')
- TRACKARTIST=$(echo "$DTITLEARTIST" | cut -f2 -d~)
- TRACKNAME=$(echo "$DTITLEARTIST" | cut -f1 -d~)
+ DTITLEARTIST="$(echo "$TRACKNAME" | sed 's- / -~-g')"
+ TRACKARTIST="$(echo "$DTITLEARTIST" | cut -f2 -d~)"
+ TRACKNAME="$(echo "$DTITLEARTIST" | cut -f1 -d~)"
;;
reverse-dash)
- DTITLEARTIST=$(echo "$TRACKNAME" | sed 's, - ,~,g')
- TRACKARTIST=$(echo "$DTITLEARTIST" | cut -f2 -d~)
- TRACKNAME=$(echo "$DTITLEARTIST" | cut -f1 -d~)
+ DTITLEARTIST="$(echo "$TRACKNAME" | sed 's, - ,~,g')"
+ TRACKARTIST="$(echo "$DTITLEARTIST" | cut -f2 -d~)"
+ TRACKNAME="$(echo "$DTITLEARTIST" | cut -f1 -d~)"
;;
colon)
- DTITLEARTIST=$(echo "$TRACKNAME" | sed 's-: -~-g')
- TRACKARTIST=$(echo "$DTITLEARTIST" | cut -f1 -d~)
- TRACKNAME=$(echo "$DTITLEARTIST" | cut -f2 -d~)
+ DTITLEARTIST="$(echo "$TRACKNAME" | sed 's-: -~-g')"
+ TRACKARTIST="$(echo "$DTITLEARTIST" | cut -f1 -d~)"
+ TRACKNAME="$(echo "$DTITLEARTIST" | cut -f2 -d~)"
;;
trailing-paren)
- DTITLEARTIST=$(echo "$TRACKNAME" | sed 's,^\(.*\) (\(.*\)),\1~\2,')
- TRACKARTIST=$(echo "$DTITLEARTIST" | cut -f2 -d~)
- TRACKNAME=$(echo "$DTITLEARTIST" | cut -f1 -d~)
+ DTITLEARTIST="$(echo "$TRACKNAME" | sed 's,^\(.*\) (\(.*\)),\1~\2,')"
+ TRACKARTIST="$(echo "$DTITLEARTIST" | cut -f2 -d~)"
+ TRACKNAME="$(echo "$DTITLEARTIST" | cut -f1 -d~)"
;;
esac
elif [ "$VARIOUSARTISTS" = "y" ] && [ "$ONETRACK" = "y" ]; then
# ''' -> ''
# '?' -> ''
# Eat control characters
- ALBUMFILE=$(mungefilename "$DALBUM")
- ARTISTFILE=$(mungefilename "$TRACKARTIST")
- TRACKFILE=$(mungefilename "$TRACKNAME")
- GENRE=$(mungegenre "$GENRE")
- YEAR=$(echo $CDYEAR)
+ ALBUMFILE="$(mungefilename "$DALBUM")"
+ ARTISTFILE="$(mungefilename "$TRACKARTIST")"
+ TRACKFILE="$(mungefilename "$TRACKNAME")"
+ GENRE="$(mungegenre "$GENRE")"
+ YEAR="$(echo $CDYEAR)"
# If we want to start the tracks with a given number, we need to modify the
# TRACKNUM value before evaluation
# if [ -n "$STARTTRACKNUMBER" ] ; then
# Supported variables for OUTPUTFORMAT are GENRE, ALBUMFILE, ARTISTFILE,
# TRACKFILE, and TRACKNUM.
if [ "$VARIOUSARTISTS" = "y" ]; then
- OUTPUTFILE=$(eval echo $VAOUTPUTFORMAT)
- else
- OUTPUTFILE=$(eval echo $OUTPUTFORMAT)
+ OUTPUTFILE="$(eval echo "$VAOUTPUTFORMAT")"
+ else
+ OUTPUTFILE="$(eval echo "$OUTPUTFORMAT")"
fi
if checkerrors "tagtrack-$OUTPUT-$1"; then :; else
# Once we know the specific output was successful, we can change the OUTPUT to the value containing the container
;;
esac
# Check that the directory for OUTPUTFILE exists, if it doesn't, create it
- OUTPUTFILEDIR=$(dirname "$OUTPUTDIR/$OUTPUTFILE")
+ OUTPUTFILEDIR="$(dirname "$OUTPUTDIR/$OUTPUTFILE")"
# mkdir -p shouldn't return an error if the directory already exists
mkdir -p "$OUTPUTFILEDIR"
run_command movetrack-$1 mv "$ABCDETEMPDIR/track$1.$OUTPUT" "$OUTPUTDIR/$OUTPUTFILE.$OUTPUT"
# Create a playlist file for the playlist data to go into.
# We used to wipe it out if it existed. Now we request permision if interactive.
for LASTTRACK in $TRACKQUEUE; do :; done
- ALBUMFILE=$(mungefilename "$DALBUM")
- ARTISTFILE=$(mungefilename "$DARTIST")
+ ALBUMFILE="$(mungefilename "$DALBUM")"
+ ARTISTFILE="$(mungefilename "$DARTIST")"
GENRE=$(mungegenre "$GENRE")
YEAR=${CDYEAR:-$CDYEAR}
if [ "$VARIOUSARTISTS" = "y" ] ; then
#TRACKNAME=$(grep ^TTITLE$CDDBTRACKNUM= "$CDDBDATA" | cut -f2 -d= | tr -d \[:cntrl:\] | sed 's/\ \+$//')
do_getcddbinfo TRACKNAME
splitvarious
- TRACKFILE=$(mungefilename "$TRACKNAME")
- ARTISTFILE=$(mungefilename "$TRACKARTIST")
- ALBUMFILE=$(mungefilename "$DALBUM")
+ TRACKFILE="$(mungefilename "$TRACKNAME")"
+ ARTISTFILE="$(mungefilename "$TRACKARTIST")"
+ ALBUMFILE="$(mungefilename "$DALBUM")"
# If we want to start the tracks with a given number, we need to modify the
# TRACKNUM value before evaluation
# if [ -n "$STARTTRACKNUMBER" ] ; then
fi
do_cddbedit
- eval $($CDDBTOOL parse "$CDDBDATA")
+ eval "$($CDDBTOOL parse "$CDDBDATA")"
fi
# Before reading tracks, we set the speed of the device
set -e
# names chosen to match usage in abcde code
DISCID=$(grep ^DISCID= "$CDDBFILE" | cut -f2 -d= | tr -d \[:cntrl:\])
- DARTISTALBUM=$(grep ^DTITLE= "$CDDBFILE" | cut -f2- -d= | tr -d \\n | sed 's- / -~-g' | tr -d \[:cntrl:\])
- DARTIST=$(echo "$DARTISTALBUM" | cut -f1 -d~ | sed 's,\\,\\\\,g;s,\([\"\$\`]\),\\\1,g' | tr -d \[:cntrl:\])
- DALBUM=$(echo "$DARTISTALBUM" | cut -f2 -d~ | sed 's,\\,\\\\,g;s,\([\"\$\`]\),\\\1,g' | tr -d \[:cntrl:\])
- CDDBGENRE=$(grep '^#CATEGORY=' "$CDDBFILE" | cut -f2- -d= | tr -d \[:cntrl:\])
+ DARTISTALBUM="$(grep ^DTITLE= "$CDDBFILE" | cut -f2- -d= | tr -d \\n | sed 's- / -~-g' | tr -d \[:cntrl:\])"
+ DARTIST="$(echo "$DARTISTALBUM" | cut -f1 -d~ | sed 's,\\,\\\\,g;s,\([\"\$\`]\),\\\1,g' | tr -d \[:cntrl:\])"
+ DALBUM="$(echo "$DARTISTALBUM" | cut -f2 -d~ | sed 's,\\,\\\\,g;s,\([\"\$\`]\),\\\1,g' | tr -d \[:cntrl:\])"
+ CDDBGENRE="$(grep '^#CATEGORY=' "$CDDBFILE" | cut -f2- -d= | tr -d \[:cntrl:\])"
if grep "^DYEAR" "$CDDBFILE" 2>&1 > /dev/null ; then
CDYEAR=$(grep "^DYEAR" "$CDDBFILE" | cut -f2- -d= | tr -d \[:cntrl:\])
elif grep YEAR "$CDDBFILE" 2>&1 > /dev/null ; then