Fix for some erroneous error and status logging.
authorAndrew Strong <andrew.david.strong@gmail.com>
Tue, 21 Jun 2016 08:38:07 +0000 (18:38 +1000)
committerAndrew Strong <andrew.david.strong@gmail.com>
Tue, 21 Jun 2016 08:38:07 +0000 (18:38 +1000)
Thanks to Christian Wasem for the bug report and fix.
This closes Issue 32:

  https://abcde.einval.com/bugzilla/show_bug.cgi?id=32

abcde
changelog

diff --git a/abcde b/abcde
index 7b8de4b..901686a 100755 (executable)
--- a/abcde
+++ b/abcde
@@ -1066,7 +1066,7 @@ do_nogap_encode ()
                                nice $ENCNICE $MP3ENCODER $MP3ENCODEROPTS --nogap $TRACKFILES
                                RETURN=$?
                                if [ "$RETURN" != "0" ]; then
-                                       echo "nogap-encode: $ENCODER returned code $RETURN" >> errors
+                                       echo "nogap-encode: $ENCODER returned code $RETURN" >> "$ABCDETEMPDIR/errors"
                                else
                                        for UTRACKNUM in $TRACKQUEUE
                                        do
@@ -1503,11 +1503,11 @@ do_batch_gain ()
        $NORMALIZER -b $NORMALIZEROPTS $TRACKFILES
        RETURN=$?
        if [ "$RETURN" != "0" ]; then
-               echo "batch-normalize: $NORMALIZER returned code $RETURN" >> errors
+               echo "batch-normalize: $NORMALIZER returned code $RETURN" >> "$ABCDETEMPDIR/errors"
        else
                for UTRACKNUM in $TRACKQUEUE
                do
-                       echo normalizetrack-$UTRACKNUM >> status
+                       echo "normalizetrack-$UTRACKNUM" >> "$ABCDETEMPDIR/status"
                done
        fi
        )
@@ -1532,11 +1532,11 @@ do_batch_normalize ()
        $NORMALIZER -b $NORMALIZEROPTS $TRACKFILES
        RETURN=$?
        if [ "$RETURN" != "0" ]; then
-               echo "batch-normalize: $NORMALIZER returned code $RETURN" >> errors
+               echo "batch-normalize: $NORMALIZER returned code $RETURN" >> "$ABCDETEMPDIR/errors"
        else
                for UTRACKNUM in $TRACKQUEUE
                do
-                       echo normalizetrack-$UTRACKNUM >> status
+                       echo "normalizetrack-$UTRACKNUM" >> "$ABCDETEMPDIR/status"
                done
        fi
        )
index af3d091..fa525c6 100644 (file)
--- a/changelog
+++ b/changelog
@@ -1,3 +1,9 @@
+abcde 2.7.3
+
+  * Fix for some erroneous error and status logging. Thanks to Christian
+    Wasem for the bug report and fix. This closes Issue 32:
+    https://abcde.einval.com/bugzilla/show_bug.cgi?id=32
+
 abcde 2.7.2
 
   * When using musicbrainz, don't assume that there will be release