TRACKTOTAL written to ogg files
[abcde.git] / abcde
diff --git a/abcde b/abcde
index d64436c..370e327 100755 (executable)
--- a/abcde
+++ b/abcde
@@ -23,7 +23,7 @@ echo "Options:"
 echo "-1     Encode the whole CD in a single file"
 echo "-a <action1[,action2]...>"
 echo "       Actions to perform:"
-echo "       cddb,read,normalize,encode,tag,move,replaygain,playlist,clean"
+echo "       cddb,read,getalbumart,normalize,encode,tag,move,replaygain,playlist,clean"
 #echo "-A     Experimental actions (retag, transcode)"
 echo "-b     Enable batch normalization"
 echo "-c <file>"
@@ -36,6 +36,7 @@ echo "-D     Debugging mode (equivalent to sh -x abcde)"
 echo "-e     Erase encoded track information from status file"
 echo "-f     Force operations that otherwise are considered harmful. Read \"man abcde\""
 echo "-g     Use \"lame --nogap\" for MP3 encoding. Disables low disk and pipes flags"
+echo "-G     Get album art by using the 'getalbumart' action"
 echo "-h     This help information"
 #echo "-i    Tag files while encoding, when possible (local only) -NWY-"
 echo "-j <#> Number of encoder processes to run at once (localhost)"
@@ -820,7 +821,6 @@ do_tag ()
                                TPE2="Various"
                        fi
 
-
                        case "$ID3SYNTAX" in
                                id3)
                                        run_command tagtrack-$OUTPUT-$1 nice $ENCNICE \
@@ -863,7 +863,7 @@ do_tag ()
                                                        );;
                                        esac
                                        run_command tagtrack-$OUTPUT-$1 nice $ENCNICE $TAGGER $TAGGEROPTS \
-                                           -A "$DALBUM" \
+                                               -A "$DALBUM" \
                                                -a "$TRACKARTIST" -t "$TRACKNAME" \
                                                -G "$GENREID" -n "${TRACKNUM:-$1}" \
                                                ${TRACKNUM:+-N "$TRACKS"} \
@@ -885,7 +885,7 @@ do_tag ()
                                        fi
                                        (
                                        # These are from
-                                       # http://www.xiph.org/ogg/vorbis/doc/v-comment.html
+                                       # http://www.xiph.org/vorbis/doc/v-comment.html
 
                                        echo ARTIST="$TRACKARTIST"
                                        echo ALBUM="$DALBUM"
@@ -897,6 +897,11 @@ do_tag ()
                                                echo GENRE="$CDGENRE"
                                        fi
                                        echo TRACKNUMBER=${TRACKNUM:-$1}
+                                       # TRACKTOTAL is not in the proposed, minimal list of standard field names from
+                                       # xiph.org: http://www.xiph.org/vorbis/doc/v-comment.html but is in common usage
+                                       # and read by mediainfo, ffprobe, vlc, Aqualung, ogg123, Foobar. And now abcde :)
+                                       # The tag is quietly ignored by  Audacious, MPlayer, mpv, XMMS....
+                                       echo TRACKTOTAL="${TRACKS}"
                                        if [ -n "$DISCNUMBER" ]; then
                                                echo DISCNUMBER="$DISCNUMBER"
                                        fi
@@ -923,7 +928,6 @@ do_tag ()
                opus)
                        run_command tagtrack-$OUTPUT-$1 true
                        ;;
-
                flac)
                        (
                        echo ARTIST="$TRACKARTIST"
@@ -936,6 +940,11 @@ do_tag ()
                                echo GENRE="$CDGENRE"
                        fi
                        echo TRACKNUMBER="${TRACKNUM:-$1}"
+                       # TRACKTOTAL is not in the proposed, minimal list of standard field names from
+                       # xiph.org: http://www.xiph.org/vorbis/doc/v-comment.html but is in common usage
+                       # and read by mediainfo, ffprobe, vlc, Aqualung, ogg123, Foobar. And now abcde :)
+                       # The tag is quietly ignored by  Audacious, MPlayer, mpv, XMMS....
+                       echo TRACKTOTAL="${TRACKS}"
                        if [ -n "$DISCNUMBER" ]; then
                                echo DISCNUMBER="$DISCNUMBER"
                        fi
@@ -946,7 +955,8 @@ do_tag ()
                                        *)   echo COMMENT="$COMMENTOUTPUT";;
                                esac
                        fi
-                       ) | run_command tagtrack-$OUTPUT-$1 nice $ENCNICE $METAFLAC $METAFLACOPTS ${IMPORTCUESHEET:+--import-cuesheet-from="$ABCDETEMPDIR/$CUEFILE"} --import-tags-from=- "$ABCDETEMPDIR/track$1.$FLACOUTPUTCONTAINER"
+                       ) | run_command tagtrack-$OUTPUT-$1 nice $ENCNICE $METAFLAC $METAFLACOPTS ${IMPORTCUESHEET:+--import-cuesheet-from="$ABCDETEMPDIR/$CUEFILE"} \
+                       --import-tags-from=- "$ABCDETEMPDIR/track$1.$FLACOUTPUTCONTAINER"
                        ;;
                spx)
                        run_command tagtrack-$OUTPUT-$1 true
@@ -954,32 +964,35 @@ do_tag ()
                mpc)
                        run_command tagtrack-$OUTPUT-$1 true
                        ;;
-        wv)
-            run_command tagtrack-$OUTPUT-$1 true
+               wv)
+                       run_command tagtrack-$OUTPUT-$1 true
                        ;;
-        ape) # This tagging syntax is suitable for Robert Muth's application 'apetag', the Monkey's Audio 
-             # Console port (mac) used for encoding does not have the ability to tag.              Andrew.
-            run_command tagtrack-$OUTPUT-$1 nice $ENCNICE "$APETAG" -i "$ABCDETEMPDIR/track$1.ape" -m overwrite \
-                    -p artist="$TRACKARTIST" -p album="$DALBUM" -p title="$TRACKNAME" -p track=${TRACKNUM:-$1} \
-                    -p year="$CDYEAR" -p genre="$CDGENRE" ${COMMENTOUTPUT:+-p comment="$COMMENTOUTPUT"} 
+               ape)
+                       # This tagging syntax is suitable for Robert Muth's application 'apetag', the Monkey's Audio 
+                       # Console port (mac) used for encoding does not have the ability to tag.
+                       run_command tagtrack-$OUTPUT-$1 nice $ENCNICE "$APETAG" -i "$ABCDETEMPDIR/track$1.ape" -m overwrite \
+                       -p artist="$TRACKARTIST" -p album="$DALBUM" -p title="$TRACKNAME" -p track=${TRACKNUM:-$1} \
+                       -p year="$CDYEAR" -p genre="$CDGENRE" ${COMMENTOUTPUT:+-p comment="$COMMENTOUTPUT"} 
                        ;;
                aac)
                        run_command tagtrack-$OUTPUT-$1 true
-               ;;
-               m4a)
-                 case "$AACENCODERSYNTAX" in
-                   fdkaac) # We will use inline tagging...
-                       run_command tagtrack-$OUTPUT-$1 true
-                       ;;
-                   neroAacEnc) # Tag post encode with neroAacTag...
-                    run_command tagtrack-$OUTPUT-$1 nice $ENCNICE "$NEROAACTAG" "$ABCDETEMPDIR/track$1.m4a" \
-                    -meta:artist="$TRACKARTIST" -meta:album="$DALBUM" -meta:title="$TRACKNAME" -meta:track=${TRACKNUM:-$1} \
-                    -meta:year="$CDYEAR" -meta:genre="$CDGENRE" -meta:comment="$COMMENT"
-                     ;;
-                  faac)
-                    run_command tagtrack-$OUTPUT-$1 true                   
                        ;;
-               esac                    
+               m4a)
+                       case "$AACENCODERSYNTAX" in
+                               fdkaac)
+                                       # We will use inline tagging...
+                                       run_command tagtrack-$OUTPUT-$1 true
+                                       ;;
+                               neroAacEnc)
+                                       # Tag post encode with neroAacTag...
+                                       run_command tagtrack-$OUTPUT-$1 nice $ENCNICE "$NEROAACTAG" "$ABCDETEMPDIR/track$1.m4a" \
+                                       -meta:artist="$TRACKARTIST" -meta:album="$DALBUM" -meta:title="$TRACKNAME" -meta:track=${TRACKNUM:-$1} \
+                                       -meta:year="$CDYEAR" -meta:genre="$CDGENRE" -meta:comment="$COMMENT"
+                                       ;;
+                               faac)
+                                       run_command tagtrack-$OUTPUT-$1 true   
+                                       ;;
+                       esac
                        ;;
                wav)
                        run_command tagtrack-$OUTPUT-$1 true
@@ -989,7 +1002,6 @@ do_tag ()
        if checkerrors "tagtrack-(.{3,6})-$1"; then :; else
                run_command tagtrack-$1 true
        fi
-
 }
 
 # do_nogap_encode
@@ -1044,7 +1056,8 @@ do_nogap_encode ()
 # do_encode [tracknumber] [hostname]
 # If no hostname is specified, encode locally
 # variables used:
-# TRACKS, TRACKNAME, TRACKARTIST, DISTMP3, DISTMP3OPTS, {FOO}ENCODERSYNTAX, OUTPUTTYPE, ENCODEROPTS, DALBUM, DARTIST, ENCNICE, CDYEAR, CDGENRE, COMMENT
+# TRACKS, TRACKNAME, TRACKARTIST, DISTMP3, DISTMP3OPTS, {FOO}ENCODERSYNTAX, OUTPUTTYPE, ENCODEROPTS, 
+# DALBUM, DARTIST, ENCNICE, CDYEAR, CDGENRE, COMMENT
 do_encode ()
 {
        if [ "$USEPIPES" = "y" ]; then
@@ -1107,7 +1120,7 @@ do_encode ()
                                RUN_COMMAND=""
                                # We need a way to store the creation of the files when using PIPES
                                RUN_COMMAND_PIPES="run_command encodetrack-$OUTPUT-$1 true"
-                               # When pipping it does not make sense to have a higher nice for
+                               # When piping it does not make sense to have a higher nice for
                                # reading than for encoding, since it will be hold by the
                                # encoding process. Setting an effective nice, to calm down a
                                # bit the reading process.
@@ -1123,7 +1136,7 @@ do_encode ()
                                %local*%)
                                        case "$MP3ENCODERSYNTAX" in
                                        lame|toolame|gogo) $RUN_COMMAND nice $EFFECTIVE_NICE $MP3ENCODER $MP3ENCODEROPTS "$IN" "$OUT" ;;
-                                       bladeenc) $RUN_COMMAND nice $EFFECTIVE_NICE $MP3ENCODER $MP3ENCODEROPTS -quit "$IN" ;;
+                                       bladeenc) $RUN_COMMAND nice $EFFECTIVE_NICE $MP3ENCODER $MP3ENCODEROPTS -quit "$IN" "$OUT" ;;
                                        l3enc|xingmp3enc) $RUN_COMMAND nice $EFFECTIVE_NICE $MP3ENCODER "$IN" "$OUT" $MP3ENCODEROPTS ;;
                                        mp3enc) $RUN_COMMAND nice $EFFECTIVE_NICE $MP3ENCODER -if "$IN" -of "$OUT" $MP3ENCODEROPTS ;;
                                        esac
@@ -1151,14 +1164,15 @@ do_encode ()
                                %local*%)
                                        case "$OPUSENCODERSYNTAX" in
                                        opusenc)
-                                           # Tag the file at encode time, as it can't be done after encoding.
-                                           if [ "$DOTAG" = "y" ]; then
-                                              $RUN_COMMAND nice $EFFECTIVE_NICE $OPUSENCODER $OPUSENCODEROPTS --artist "$TRACKARTIST" --album "$DALBUM" --title "$TRACKNAME" \
-                                              --genre "$CDGENRE" --date "$CDYEAR" --comment TRACKNUMBER="$1" ${COMMENT:+--comment COMMENT="$COMMENT"} "$IN" "$OUT"
-                                           else
-                                             $RUN_COMMAND nice $EFFECTIVE_NICE $OPUSENCODER $OPUSENCODEROPTS "$IN" "$OUT"
-                                           fi
-                                             ;;
+                                       # Tag the file at encode time, as it can't be done after encoding.
+                                               if [ "$DOTAG" = "y" ]; then
+                                                       $RUN_COMMAND nice $EFFECTIVE_NICE $OPUSENCODER $OPUSENCODEROPTS --artist "$TRACKARTIST" \
+                                                       --album "$DALBUM" --title "$TRACKNAME" --genre "$CDGENRE" --date "$CDYEAR" --comment TRACKNUMBER="$1" \
+                                                       ${COMMENT:+--comment COMMENT="$COMMENT"} "$IN" "$OUT"
+                                               else
+                                                       $RUN_COMMAND nice $EFFECTIVE_NICE $OPUSENCODER $OPUSENCODEROPTS "$IN" "$OUT"
+                                               fi
+                                       ;;
                                        esac
                                        ;;
                                *)
@@ -1189,66 +1203,65 @@ do_encode ()
                                fi
                                # Tag the file at encode time, as it can't be done after encoding.
                                if [ "$DOTAG" = "y" ]; then
-                                       $RUN_COMMAND nice $EFFECTIVE_NICE $SPEEXENCODER $SPEEXENCODEROPTS --author "$TRACKARTIST" --title "$TRACKNAME" ${COMMENT:+--comment "$COMMENT"} "$IN" "$OUT"
+                                       $RUN_COMMAND nice $EFFECTIVE_NICE $SPEEXENCODER $SPEEXENCODEROPTS --author "$TRACKARTIST" --title "$TRACKNAME" \
+                                       ${COMMENT:+--comment "$COMMENT"} "$IN" "$OUT"
                                else
                                        $RUN_COMMAND nice $EFFECTIVE_NICE $SPEEXENCODER $SPEEXENCODEROPTS "$IN" "$OUT"
                                fi
                                ;;
                        mpc)
-                       # Tag the file inline at encode time.
-                         if [ "$DOTAG" = "y" ]; then
-                                $RUN_COMMAND nice $EFFECTIVE_NICE $MPCENCODER $MPCENCODEROPTS --artist "$TRACKARTIST" --album "$DALBUM" --title "$TRACKNAME" \
-                               --track "$1" --genre "$CDGENRE" --year "$CDYEAR" ${COMMENT:+--comment "$COMMENT"} "$IN" "$OUT"
+                               # Tag the file inline at encode time.
+                               if [ "$DOTAG" = "y" ]; then
+                                       $RUN_COMMAND nice $EFFECTIVE_NICE $MPCENCODER $MPCENCODEROPTS --artist "$TRACKARTIST" --album "$DALBUM" \
+                                       --title "$TRACKNAME" --track "$1" --genre "$CDGENRE" --year "$CDYEAR" ${COMMENT:+--comment "$COMMENT"} "$IN" "$OUT"
                                else
-                                $RUN_COMMAND nice $EFFECTIVE_NICE $MPCENCODER $MPCENCODEROPTS "$IN" "$OUT"
+                                       $RUN_COMMAND nice $EFFECTIVE_NICE $MPCENCODER $MPCENCODEROPTS "$IN" "$OUT"
                                fi
                                ;;
                        wv)
-                        if [ "$DOTAG" = "y" ]; then
-             # wavpack tagging is done inline using Apev2 tags:
-                               $RUN_COMMAND nice $EFFECTIVE_NICE $WVENCODER $WVENCODEROPTS -w Artist="$TRACKARTIST" -w Album="$DALBUM" -w Title="$TRACKNAME" \
-                               -w Track="$1" -w Genre="$CDGENRE" -w Year="$CDYEAR" ${COMMENT:+-w Comment="$COMMENT"} "$IN" -o "$OUT"
-                       else
-                          $RUN_COMMAND nice $EFFECTIVE_NICE $WVENCODER $WVENCODEROPTS "$IN" -o "$OUT"
-                        fi
+                               if [ "$DOTAG" = "y" ]; then
+                                       $RUN_COMMAND nice $EFFECTIVE_NICE $WVENCODER $WVENCODEROPTS -w Artist="$TRACKARTIST" -w Album="$DALBUM" \
+                                       -w Title="$TRACKNAME" -w Track="$1" -w Genre="$CDGENRE" -w Year="$CDYEAR" ${COMMENT:+-w Comment="$COMMENT"} "$IN" -o "$OUT"
+                               else
+                                       $RUN_COMMAND nice $EFFECTIVE_NICE $WVENCODER $WVENCODEROPTS "$IN" -o "$OUT"
+                               fi
                                ;;
                        ape)
-                         $RUN_COMMAND nice $EFFECTIVE_NICE $APENCODER "$IN" "$OUT" $APENCODEROPTS
-                        ;;
+                               $RUN_COMMAND nice $EFFECTIVE_NICE $APENCODER "$IN" "$OUT" $APENCODEROPTS
+                               ;;
                        aac)
-                       # aac container is only used to catch faac encoded files where faac 
-                       # is compiled without mp4 support (with libmp4v2).           Andrew.
-                         $RUN_COMMAND nice $EFFECTIVE_NICE $AACENCODER $AACENCODEROPTS -o "$OUT" "$IN"
-                        ;;
+                               # aac container is only used to catch faac encoded files where faac 
+                               # is compiled without mp4 support (with libmp4v2).
+                               $RUN_COMMAND nice $EFFECTIVE_NICE $AACENCODER $AACENCODEROPTS -o "$OUT" "$IN"
+                               ;;
                        m4a)
-                        case "$AACENCODERSYNTAX" in
-                          faac)
-                            if [ "$DOTAG" = "y" ]; then
-                  $RUN_COMMAND nice $EFFECTIVE_NICE $AACENCODER $AACENCODEROPTS  --artist "$TRACKARTIST" \
-                  --album "$DALBUM" --title "$TRACKNAME" --track ${TRACKNUM:-$1} --year "$CDYEAR" \
-                  --genre "$CDGENRE" --comment "$COMMENT" -o "$OUT" "$IN"                                
-                else                    
-                  $RUN_COMMAND nice $EFFECTIVE_NICE $AACENCODER $AACENCODEROPTS -o "$OUT" "$IN"        
-                fi
-                          ;;
-                          neroAacEnc)
-                   $RUN_COMMAND nice $EFFECTIVE_NICE $AACENCODER $AACENCODEROPTS -if "$IN" -of "$OUT"
-                          ;;
-                        fdkaac)                     
-                       if [ "$DOTAG" = "y" ]; then
-                         $RUN_COMMAND nice $EFFECTIVE_NICE $AACENCODER $AACENCODEROPTS --artist "$TRACKARTIST" --album "$DALBUM" \
-                         --title "$TRACKNAME" --track "$1" --genre "$CDGENRE" --date "$CDYEAR" --comment "$COMMENT" "$IN" -o "$OUT"
-                           else
-                    $RUN_COMMAND nice $EFFECTIVE_NICE $AACENCODER $AACENCODEROPTS "$IN" -o "$OUT"      
-                           fi
-                ;;
-                         esac  
+                               case "$AACENCODERSYNTAX" in
+                                       faac)
+                                               if [ "$DOTAG" = "y" ]; then
+                                                       $RUN_COMMAND nice $EFFECTIVE_NICE $AACENCODER $AACENCODEROPTS  --artist "$TRACKARTIST" --album "$DALBUM" \
+                                                       --title "$TRACKNAME" --track ${TRACKNUM:-$1} --year "$CDYEAR" --genre "$CDGENRE" --comment "$COMMENT" -o "$OUT" "$IN"
+                                               else 
+                                                       $RUN_COMMAND nice $EFFECTIVE_NICE $AACENCODER $AACENCODEROPTS -o "$OUT" "$IN"   
+                                               fi
+                                               ;;
+                                       neroAacEnc)
+                                               $RUN_COMMAND nice $EFFECTIVE_NICE $AACENCODER $AACENCODEROPTS -if "$IN" -of "$OUT"
+                                               ;;
+                                       fdkaac)      
+                                               if [ "$DOTAG" = "y" ]; then
+                                                       $RUN_COMMAND nice $EFFECTIVE_NICE $AACENCODER $AACENCODEROPTS --artist "$TRACKARTIST" --album "$DALBUM" \
+                                                       --title "$TRACKNAME" --track "$1" --genre "$CDGENRE" --date "$CDYEAR" --comment "$COMMENT" "$IN" -o "$OUT"
+                                               else
+                                                       $RUN_COMMAND nice $EFFECTIVE_NICE $AACENCODER $AACENCODEROPTS "$IN" -o "$OUT"
+                                               fi
+                                               ;;
+                                       esac
                                ;;
                        wav)
                                # In case of wav output we need nothing. Just keep the wavs.
                                # But we need the following to allow full logging and subsequent 
-                               # successful cleaning of $ABCDETEMPDIR. Andrew.
-             echo "encodetrack-$OUTPUT-$UTRACKNUM" >> "$ABCDETEMPDIR/status"
+                               # successful cleaning of $ABCDETEMPDIR.
+                               echo "encodetrack-$OUTPUT-$UTRACKNUM" >> "$ABCDETEMPDIR/status"
                                ;;
                        esac
                        $RUN_COMMAND_PIPES
@@ -1931,7 +1944,7 @@ do_discid ()
        if [ -z "$TRACKQUEUE" ]; then
                if [ ! "$STRIPDATATRACKS" = "n" ]; then
                        case "$CDROMREADERSYNTAX" in
-                               cdparanoia|debug)
+                               cdparanoia|libcdio|debug)
                                        if [ "$WEHAVEACD" = "y" ]; then
                                                vecho "Querying the CD for audio tracks..."
                                                CDPARANOIAOUTPUT="$( $CDROMREADER -$CDPARANOIACDROMBUS "$CDROM" -Q --verbose 2>&1 )"
@@ -2973,6 +2986,132 @@ do_cddbedit ()
        echo "cddb-edit" >> "$ABCDETEMPDIR/status"
 }
 
+# do_getalbumart
+# try to download CD cover
+do_getalbumart()
+{
+       # set variables
+       ALBUMFILE="$(mungefilename "$DALBUM")"
+       ARTISTFILE="$(mungefilename "$DARTIST")"
+       # have we got a musicbrainz mbid or amazon asin?
+       case "$CDDBMETHOD" in
+               musicbrainz)
+                       # try musicbrainz mbid
+                       if [ -s "$ABCDETEMPDIR/mbid.$(checkstatus cddb-choice)" ]; then
+                               MBID=$(cat "$ABCDETEMPDIR/mbid.$(checkstatus cddb-choice)")
+                               vecho "trying to get cover from coverartarchive.orq with musicbrainz mbid $MBID" >&2
+                               ALBUMARTURL="http://coverartarchive.org/release/$MBID/front"
+                               vecho "cover URL: $ALBUMARTURL" >&2
+                               $HTTPGET "$ALBUMARTURL" > "$ABCDETEMPDIR/$ALBUMARTFILE"
+                               if [ $? -ne 0 ]; then
+                                       vecho "could not download cover from musicbrainz" >&2
+                                       # try amazon asin
+                                       if [ -s "$ABCDETEMPDIR/asin.$(checkstatus cddb-choice)" ]; then
+                                               ASIN=$(cat "$ABCDETEMPDIR/asin.$(checkstatus cddb-choice)")
+                                               vecho "trying to get cover from amazon.com with asin $ASIN" >&2
+                                               ALBUMARTURL="http://ec1.images-amazon.com/images/P/$ASIN.01.LZZZZZZZZ.jpg"
+                                               vecho "cover URL: $ALBUMARTURL" >&2
+                                               $HTTPGET "$ALBUMARTURL" > "$ABCDETEMPDIR/$ALBUMARTFILE"
+                                               if [ $? -ne 0 ]; then
+                                                       vecho "could not download cover from amazon" >&2
+                                               fi
+                                       else
+                                               vecho "no amazon ID found" >&2
+                                       fi
+                               fi
+                       else
+                               vecho "no musicbrainz ID found" >&2
+                       fi
+                       ;;
+       esac
+       # use glyrc
+       if [ ! -s "$ABCDETEMPDIR/$ALBUMARTFILE" ]; then
+               vecho "trying to get cover with glyrc for $ARTISTFILE / $ALBUMFILE" >&2
+               $GLYRC cover --artist "$ARTISTFILE" --album "$ALBUMFILE" --write "$ABCDETEMPDIR/$ALBUMARTFILE" $GLYRCOPTS
+               if [ $? -ne 0 ]; then
+                       vecho "could not download cover with glyrc" >&2
+               else
+                       ALBUMARTURL="glyrc"
+               fi
+       fi
+       if [ "$INTERACTIVE" = "y" ]; then
+               if [ -s "$ABCDETEMPDIR/$ALBUMARTFILE" ]; then
+                       # display properties of coverart when identify is available
+                       if new_checkexec $IDENTIFY; then
+                               $IDENTIFY $IDENTIFYOPTS "$ABCDETEMPDIR/$ALBUMARTFILE" >&2
+                       fi
+                       # display coverart when DISPLAY is set and display command is available
+                       if new_checkexec $DISPLAYCMD && [ "$DISPLAY" != "" ]; then
+                               $DISPLAYCMD $DISPLAYCMDOPTS "$ABCDETEMPDIR/$ALBUMARTFILE" >&2 &
+                       fi
+               else
+                       # nothing downloaded yet
+                       vecho "automatic album art downloading failed" >&2
+               fi
+               # see if the user can find a better album art manually
+               echo -n "Do you want to enter URL or local path for the album art [y/N]? " >&2
+               read YESNO
+               while [ "$YESNO" != "y" ] && [ "$YESNO" != "n" ] && [ "$YESNO" != "Y" ] && \
+                       [ "$YESNO" != "N" ] && [ "$YESNO" != "" ]
+               do
+                       echo -n 'Invalid selection. Please answer "y" or "n": ' >&2
+                       read YESNO
+               done
+               if [ "$YESNO" = "y" ] || [ "$YESNO" = "Y" ]; then
+                       echo -n "Enter URL or local path (ENTER to cancel) :" >&2
+                       read ALBUMARTURL
+                       if [ ! -z "$ALBUMARTURL" ]; then
+                               if [[ ${ALBUMARTURL} =~ (https?|ftp|file)://.* ]]; then
+                                       $HTTPGET "$ALBUMARTURL" > "$ABCDETEMPDIR/$ALBUMARTFILE"
+                                       if [ ! -s "$ABCDETEMPDIR/$ALBUMARTFILE" ]; then
+                                               vecho "unable to download $ALBUMARTURL" >&2
+                                       fi
+                               else # it's a local path
+                                       cp "$ALBUMARTURL" "$ABCDETEMPDIR/$ALBUMARTFILE"
+                                       if [ ! -s "$ABCDETEMPDIR/$ALBUMARTFILE" ]; then
+                                               vecho "unable to copy $ALBUMARTURL to $ABCDETEMPDIR/$ALBUMARTFILE" >&2
+                                       fi
+                               fi
+                       fi
+               fi
+       fi
+       # convert to ALBUMARTTYPE if ImageMagick is available, if not assume correct type
+       if [ -s "$ABCDETEMPDIR/$ALBUMARTFILE" ] && new_checkexec $IDENTIFY; then
+               ALBUMARTURLTYPE=$($IDENTIFY "$ABCDETEMPDIR/$ALBUMARTFILE" | cut -d' ' -f2)
+               if [ "$ALBUMARTURLTYPE" != "$ALBUMARTTYPE" -o "$ALBUMARTALWAYSCONVERT" = "y" ]; then
+                       if new_checkexec $CONVERT; then
+                               mv "$ABCDETEMPDIR/$ALBUMARTFILE" "$ABCDETEMPDIR/$ALBUMARTFILE.tmp"
+                               $CONVERT "$ABCDETEMPDIR/$ALBUMARTFILE.tmp" $CONVERTOPTS "$ABCDETEMPDIR/$ALBUMARTFILE"
+                               rm -f "$ABCDETEMPDIR/$ALBUMARTFILE.tmp"
+                       else
+                               rm -f "$ABCDETEMPDIR/$ALBUMARTFILE"
+                               vecho "sorry, cannot convert $ALBUMARTURLTYPE to $ALBUMARTTYPE without ImageMagick convert" >&2
+                       fi
+               fi
+       fi
+       # copy to target directories
+       if [ -s "$ABCDETEMPDIR/$ALBUMARTFILE" ]; then
+               for OUTPUT in $(echo $OUTPUTTYPE | tr , \ )
+               do
+                       # put cover in the same place as the album
+                       if [ "$VARIOUSARTISTS" = "y" ] ; then
+                               ALBUMARTDIR="$(eval echo "$VAOUTPUTFORMAT")"
+                       else
+                               ALBUMARTDIR="$(eval echo "$OUTPUTFORMAT")"
+                       fi
+                       FINALALBUMARTDIR="$(dirname "$OUTPUTDIR/$ALBUMARTDIR")"
+                       vecho "copying cover to target directory $FINALALBUMARTDIR" >&2
+                       mkdir -p "$FINALALBUMARTDIR"
+                       cp "$ABCDETEMPDIR/$ALBUMARTFILE" "$FINALALBUMARTDIR"
+               done
+               rm -f "$ABCDETEMPDIR/$ALBUMARTFILE"
+               echo "get-album-art=$ALBUMARTURL" >> "$ABCDETEMPDIR/status"
+       else
+               log warning "could not get cover"
+               echo "get-album-art=none" >> "$ABCDETEMPDIR/status"
+       fi
+}
+
 # do_cdread [tracknumber]
 # do_cdread onetrack [firsttrack] [lasttrack]
 #
@@ -2990,7 +3129,7 @@ do_cdread ()
                UTRACKNUM=$FIRSTTRACK
                case "$CDROMREADERSYNTAX" in
                        flac) READTRACKNUMS="$FIRSTTRACK.1-$(($LASTTRACK + 1)).0" ;;
-                       cdparanoia)
+                       cdparanoia|libcdio)
                                #XX FIXME XX
                                # Add a variable to check if tracks are provided in command line and if not, use "0-" to rip the tracks
                                READTRACKNUMS="$FIRSTTRACK-$LASTTRACK" ;;
@@ -3011,13 +3150,10 @@ do_cdread ()
        else
                WAVDATA="$ABCDETEMPDIR/track$UTRACKNUM.wav"
                case "$CDROMREADERSYNTAX" in
-               ## FIXME ## Find the cases for dagrab and flac, to avoid exceptions
+               ## FIXME ## Find the cases for flac, to avoid exceptions
                        flac)
                                FILEARG="--output-name=$WAVDATA"
                                ;;
-                       dagrab)
-                               FILEARG="-f $WAVDATA"
-                               ;;
                        *)
                                FILEARG="$WAVDATA"
                                ;;
@@ -3041,7 +3177,7 @@ do_cdread ()
                        # Avoid problems with math expressions by unpadding the given UTRACKNUM
                        STRIPTRACKNUM=$(expr $UTRACKNUM + 0)
                        nice $READNICE $FLAC -d -f --cue=${READTRACKNUMS:-$STRIPTRACKNUM.1-$(($STRIPTRACKNUM + 1)).0} "$FILEARG" "$CDROM" ;;
-               cdparanoia)
+               cdparanoia|libcdio)
                        nice $READNICE $CDROMREADER -$CDPARANOIACDROMBUS "$CDROM" ${READTRACKNUMS:-$UTRACKNUM} "$FILEARG" $REDIR ;;
                cdda2wav | icedax)
                        if [ "$OSFLAVOUR" = "OSX" ] ; then
@@ -3059,10 +3195,16 @@ do_cdread ()
                                fi
                        fi
                        nice $READNICE $CDROMREADER -D $CDDA2WAVCDROM -t ${READTRACKNUMS:-$UTRACKNUM} "$FILEARG" $REDIR ;;
-               ## FIXME ## We have an exception for dagrab, since it uses -f
-               ## FIXME ## Shall we just use -f $FILEARG ??
-               dagrab) nice $READNICE $CDROMREADER -d "$CDROM" -v $UTRACKNUM "$FILEARG" $REDIR;;
-               pird) nice $READNICE $CDROMREADER -j ${READTRACKNUMS:-$UTRACKNUM} "$CDROM" "$FILEARG" $REDIR ;;
+               dagrab) nice $READNICE $CDROMREADER -d "$CDROM" -f "$FILEARG" -v $UTRACKNUM >&2 ;;
+               pird)
+                       if [ "$USEPIPES" = "y" ]; then
+                               nice $READNICE $CDROMREADER -j ${READTRACKNUMS:-$UTRACKNUM} "$CDROM" "$FILEARG"
+                       else
+                               # Write ripped audio data to stdout and redirect to $FILEARG.
+                               # $REDIR can be ignored. Progress is written to stderr by default.
+                               nice $READNICE $CDROMREADER -j ${READTRACKNUMS:-$UTRACKNUM} "$CDROM" "$PIPERIPPER_pird" > "$FILEARG"
+                       fi
+                       ;;
                cddafs)
                        # Find the track's mounted path
                        REALTRACKNUM=$(expr $UTRACKNUM + 0)
@@ -3287,18 +3429,19 @@ WVENC=wavpack
 APENC=mac
 APETAG=apetag
 # m4a
-AACENC=faac
+FAAC=faac
+NEROAACENC=neroAacEnc
+FDKAAC=fdkaac
 
 ID3=id3
 ID3V2=id3v2
 EYED3=eyeD3
 VORBISCOMMENT=vorbiscomment
 METAFLAC=metaflac
-AACTAG=faac
 NEROAACTAG=neroAacTag
-FDKAAC=fdkaac
 
 CDPARANOIA=cdparanoia
+CD_PARANOIA=cd-paranoia
 CDDA2WAV=icedax
 DAGRAB=dagrab
 CDDAFS=cp
@@ -3323,6 +3466,10 @@ MKCUE=mkcue
 MKTOC=cdrdao
 DIFF=diff
 CUE2DISCID=builtin
+GLYRC=glyrc
+IDENTIFY=identify
+CONVERT=convert
+DISPLAYCMD=display
 
 # Options for programs called from abcde
 # mp3
@@ -3354,14 +3501,19 @@ MPCENCOPTS=
 WVENCOPTS=
 # ape
 # Monkey's Audio Console (mac) chokes without a mode setting
-# so we set one here.                                 Andrew.
+# so we set one here.
 APENCOPTS='-c4000'
 # m4a
-AACENCOPTS=
+FAACENCOPTS=
+NEROACENCOPTS=
+# fdkaac chokes without either a bitrate or bitrate-mode specified so 
+# we set bitrate here.
+FDKAACENCOPTS='--bitrate 192k'
 
 ID3OPTS=
 EYED3OPTS=""
 CDPARANOIAOPTS=
+PIRDOPTS=
 CDDA2WAVOPTS=
 DAGRABOPTS=
 CDDAFSOPTS="-f"
@@ -3376,6 +3528,15 @@ MKTOCOPTS=""
 VORBISCOMMENTOPTS="-R"
 METAFLACOPTS="--no-utf8-convert"
 DIFFOPTS=
+GLYRCOPTS=
+IDENTIFYOPTS=
+CONVERTOPTS=
+DISPLAYCMDOPTS="-resize 512x512 -title abcde_album_art"
+
+# Defaults for album art downloads
+ALBUMARTFILE="cover.jpg"
+ALBUMARTTYPE="JPEG"
+ALBUMARTALWAYSCONVERT="n"
 
 # Default to one process if -j isn't specified
 MAXPROCS=1
@@ -3388,7 +3549,7 @@ ACTIONS=cddb,read,encode,tag,move,clean
 DEFAULT_OUTPUT_BINARIES=vorbis:oggenc,flac:flac,mp3:toolame,mp3:lame,mp3:bladeenc,spx:speex,m4a:faac:opus
 
 # List of preferred cdromreaders - by default, run whichever we have in the path
-DEFAULT_CDROMREADERS="cdparanoia icedax cdda2wav pird"
+DEFAULT_CDROMREADERS="cdparanoia icedax cdda2wav libcdio pird"
 
 # Assume fetch if under FreeBSD. curl is used for Mac OS X. wget is used for
 # Linux/OpenBSD. ftp is user for NetBSD.
@@ -3468,7 +3629,7 @@ fi
 if [ "$CDROM" = "" ] ; then
        if [ -e /dev/cdroms/cdrom0 ]; then
                CDROM=/dev/cdroms/cdrom0
-       elif [ "$OSFLAVOUR" = "OSX" ] && [[ $(diskutil list) =~ CD_part.*(disk.)$'\n' ]]; then
+       elif [ "$OSFLAVOUR" = "OSX" ] && [[ $(diskutil list) =~ CD_part[^/]*(disk.)$'\n' ]]; then
                CDROM=/dev/${BASH_REMATCH[1]}
        elif [ -e /dev/cdrom ]; then
                CDROM=/dev/cdrom
@@ -3496,7 +3657,7 @@ case "$EXTRAVERBOSE" in
 esac
 
 # Parse command line options
-while getopts 1a:bc:C:d:Defghj:klLmMnNo:pPr:s:S:t:T:UvVxX:w:W:z opt ; do
+while getopts 1a:bc:C:d:DefgGhj:klLmMnNo:pPr:s:S:t:T:UvVxX:w:W:z opt ; do
        case "$opt" in
                1) ONETRACK=y ;;
                a) ACTIONS="$OPTARG" ;;
@@ -3511,6 +3672,7 @@ while getopts 1a:bc:C:d:Defghj:klLmMnNo:pPr:s:S:t:T:UvVxX:w:W:z opt ; do
                E) ENCODING="$OPTARG" ;;
                f) FORCE=y ;;
                g) NOGAP=y ;;
+               G) GETALBUMART=y ;;
                i) INLINETAG=y ;;
                j) MAXPROCS="$OPTARG" ;;
                k) KEEPWAVS=y ;;
@@ -3606,7 +3768,7 @@ if [ "$ONETRACK" = "y" ]; then
        # FIXME # remove check as soon as we find out about the other readers
        case "$CDROMREADERSYNTAX" in
                flac) ;;
-               cdparanoia) ;;
+               cdparanoia | libcdio) ;;
                cdda2wav | icedax) ;;
                pird) ;;
                *) log error "$CDROMREADERSYNTAX does not support ONETRACK mode"
@@ -3679,6 +3841,7 @@ do
                replaygain) DOCDDB=y; DOREAD=y; DOENCODE=y; DOTAG=y; DOMOVE=y; DOREPLAYGAIN=y;;
                playlist) DOCDDB=y; DOPLAYLIST=y;;
                clean) DOCLEAN=y;;
+               getalbumart) GETALBUMART=y;;
        esac
 done
 
@@ -3795,6 +3958,12 @@ case "$CDROMREADERSYNTAX" in
                CDROMREADER="$CDPARANOIA"
                CDROMREADEROPTS="$CDPARANOIAOPTS"
                ;;
+       libcdio)
+               # GNU's libcdio package will use cd-paranoia but I believe will be happy with
+               # the standard cdparanoia options. If I am wrong this will need to be fixed :).
+               CDROMREADER="$CD_PARANOIA"
+               CDROMREADEROPTS="$CDPARANOIAOPTS"
+               ;;
        cdda2wav | icedax)
                CDROMREADER="$CDDA2WAV"
                CDROMREADEROPTS="$CDDA2WAVOPTS"
@@ -3898,14 +4067,15 @@ do
                        [ "$DOTAG" = "y" ] && NEEDAPETAG=y
                        ;;
                aac)
-                   [ "$AACENCODERSYNTAX" = "default" ] && AACENCODERSYNTAX=faac
+                       [ "$AACENCODERSYNTAX" = "default" ] && AACENCODERSYNTAX=faac
                        [ "$DOTAG" = "n" ]
                # Neither Faac nor AtomicParsley can tag the .aac files which are used for faac
                # compiled without libmp4v2... Andrew.
-                       ;;      
+                       ;;
                m4a)
                        [ "$AACENCODERSYNTAX" = "default" ] && AACENCODERSYNTAX=faac
                        [ "$DOTAG" = "y" ] && CHECKFAACBUILD=y
+                       [ "$AACENCODERSYNTAX" = "neroAacEnc" ] && NEEDNEROAACTAG=y
                        ;;
                wav)
                        if [ "$KEEPWAVS" = "y" ]; then
@@ -4009,9 +4179,35 @@ case "$APENCODERSYNTAX" in
                ;;
 esac
 case "$AACENCODERSYNTAX" in
-       faac|neroAacEnc|fdkaac)
-               AACENCODEROPTS="${AACENCODEROPTSCLI:-$AACENCOPTS}"
-               AACENCODER="$AACENC"
+               # Some elaborate 'if' work to keep backward compatability for those
+               # who don't realise that AACENCOPTS does not work with abcde from
+               # version 2.6.1 onwards.
+       faac)
+               if [ -z "$FAACENCOPTS" ] && [ -n "$AACENCOPTS" ]; then
+                       AACENCODEROPTS="${AACENCODEROPTSCLI:-$AACENCOPTS}"
+                       AACENCODER="$FAAC"
+               else
+                       AACENCODEROPTS="${AACENCODEROPTSCLI:-$FAACENCOPTS}"
+                       AACENCODER="$FAAC"
+               fi
+               ;;
+       neroAacEnc)
+               if [ -z "$NEROAACENCOPTS" ] && [ -n "$AACENCOPTS" ]; then
+                       AACENCODEROPTS="${AACENCODEROPTSCLI:-$AACENCOPTS}"
+                       AACENCODER="$NEROAACENC"
+               else        
+                       AACENCODEROPTS="${AACENCODEROPTSCLI:-$NEROAACENCOPTS}"
+                       AACENCODER="$NEROAACENC"
+               fi
+               ;;
+       fdkaac)
+               if [ -z "$FDKAACENCOPTS" ] && [ -n "$AACENCOPTS" ]; then
+                       AACENCODEROPTS="${AACENCODEROPTSCLI:-$AACENCOPTS}"
+                       AACENCODER="$FDKAAC"
+               else
+                       AACENCODEROPTS="${AACENCODEROPTSCLI:-$FDKAACENCOPTS}"
+                       AACENCODER="$FDKAAC"
+               fi
                ;;
 esac
 
@@ -4118,7 +4314,7 @@ fi
 
 if [ X"$CDSPEEDVALUE" != "X" ] && [ "$DOREAD" = "y" ]; then
        case "$CDROMREADERSYNTAX" in
-               cdparanoia|debug) CDROMREADEROPTS="$CDPARANOIAOPTS -S $CDSPEEDVALUE" ;;
+               cdparanoia|libcdio|debug) CDROMREADEROPTS="$CDPARANOIAOPTS -S $CDSPEEDVALUE" ;;
                pird) CDROMREADEROPTS="$PIRDOPTS -s $CDSPEEDVALUE" ;;
                ### FIXME ### translate "cue2discid" from python to bash
                flac) NEEDMETAFLAC=y ; NEEDCUE2DISCID=y ; CDSPEEDVALUE="" ;;
@@ -4126,10 +4322,16 @@ if [ X"$CDSPEEDVALUE" != "X" ] && [ "$DOREAD" = "y" ]; then
        esac
 fi
 
+if [ "$GETALBUMART" = "y" ]; then
+       NEEDHTTPGET="y"
+       NEEDGLYRC="y"
+fi
+
 ###USEPIPESSUPPORT###
 
 # Rippers with USEPIPE support
 PIPERIPPER_cdparanoia="-"
+PIPERIPPER_libcdio="-"
 # Note that by default in abcde cdda2wav redirects to icedax.        
 PIPERIPPER_cdda2wav="-"
 PIPERIPPER_debug="-"
@@ -4139,13 +4341,19 @@ PIPERIPPER_pird="-"
 # Encoders with USEPIPE support
 PIPE_mp3enc="-sti"
 PIPE_lame="-"
-PIPE_bladeenc="-"
+PIPE_bladeenc="stdin"
 PIPE_oggenc="-"
 PIPE_opusenc="-"
 PIPE_flac="-"
 PIPE_speexenc="-"
 PIPE_mpcenc="-"
 PIPE_wavpack="-"
+PIPE_faac="-"
+# Both neroAacEnc and fdkaac seem to manage without the addition of
+# the 'ignorelength' option in PIPE_$AACENCODERSYNTAX when piping
+# in this manner.                                           Andrew.
+PIPE_neroAacEnc="-"
+PIPE_fdkaac="-"
 
 # Figure out if we can use pipes with the ripper/encoder combination
 # exit otherwise
@@ -4161,26 +4369,28 @@ if [ "$USEPIPES" = "y" ]; then
                flac)
                        PIPEENCODERSVARCHECK="PIPE_$FLACENCODERSYNTAX" ;;
                spx)
-                       PIPEENCODERSVARCHECK="PIPE_$SPEEXENCODER" ;;
+                       PIPEENCODERSVARCHECK="PIPE_$SPEEXENCODERSYNTAX" ;;
                mpc)
-                       PIPEENCODERSVARCHECK="PIPE_$MPCENCODER" ;;
+                       PIPEENCODERSVARCHECK="PIPE_$MPCENCODERSYNTAX" ;;
                wv)
-                       PIPEENCODERSVARCHECK="PIPE_$WVENCODER" ;;
+                       PIPEENCODERSVARCHECK="PIPE_$WVENCODERSYNTAX" ;;
+               m4a)
+                       PIPEENCODERSVARCHECK="PIPE_$AACENCODERSYNTAX" ;;
+               aac)
+                       PIPEENCODERSVARCHECK="PIPE_$AACENCODERSYNTAX" ;;
        esac
        decho "PIPERIPPERSVARCHECK: $( eval echo "\$$PIPERIPPERSVARCHECK" )"
        if [ "$( eval echo "\$$PIPERIPPERSVARCHECK" )" = "$" ] || \
           [ "$( eval echo "\$$PIPERIPPERSVARCHECK" )" = "" ] ; then
                log error "no support for pipes with given ripper"
-               log error "read the USEPIPES file from the source tarball to get help."
-               log error "On a Debian system, it is under /usr/share/doc/abcde/USEPIPES.gz"
+               log error "read the FAQ file from the source tarball to get help."
                exit 1;
        fi
        decho "PIPEENCODERSVARCHECK: $( eval echo "\$$PIPEENCODERSVARCHECK" )"
        if [ "$( eval echo "\$$PIPEENCODERSVARCHECK" )" = "$" ] || \
           [ "$( eval echo "\$$PIPEENCODERSVARCHECK" )" = "" ] ; then
                log error "no support for pipes with given encoder"
-               log error "read the USEPIPES file from the source tarball to help"
-               log error "on a Debian system, read /usr/share/doc/abcde/USEPIPES.gz"
+               log error "read the FAQ file from the source tarball to get help"
                exit 1;
        fi
 fi
@@ -4196,7 +4406,8 @@ for X in $CDROMREADER $CDDISCID ${NEEDTAGGER+$TAGGER} $MP3ENCODER \
        ${NEEDVORBISGAIN+$VORBISGAIN} ${NEEDMP3GAIN+$MP3GAIN} \
        ${NEEDMPCGAIN+$MPCGAIN} ${NEEDCUEREADER+$CUEREADER} \
        ${NEEDWVGAIN+WVGAIN} ${NEEDAPETAG+$APETAG} \
-       ${NEEDCUE2DISCID+$CUE2DISCID}
+       ${NEEDCUE2DISCID+$CUE2DISCID} ${NEEDNEROAACTAG+$NEROAACTAG} \
+       ${NEEDGLYRC+$GLYRC}
 do
        checkexec "$X"
 done
@@ -4205,16 +4416,17 @@ done
 # for the mp4 container and no tagging capability. (AtomicParsley also cannot tag
 # these files). The resulting files are actually ADTS streams which belong in an 
 # aac container and with some version sniffing this is all cleaned up below. If
-# faac is compiled with libmp4v2 inline tagging occurs with faac.         Andrew. 
+# faac is compiled with libmp4v2 inline tagging occurs with faac.
 
+# FIXME: Should this be in this location? (Better incorporated into the checks above.)
 if [ "$CHECKFAACBUILD" = "y" ] && [ "$AACENCODERSYNTAX" = "faac" ] ; then
-  if faac --help 2>&1 | grep -q -F 'MP4 support unavailable.'; then 
-   echo "WARNING: Your copy of Faac does not have mp4 support"
-   echo "WARNING: Encoding untagged files to aac..."
-   OUTPUTTYPE=aac
-  else
-   echo "Using Faac to Tag AAC Tracks..."
-  fi
+       if faac --help 2>&1 | grep -q -F 'MP4 support unavailable.'; then 
+               echo "WARNING: Your copy of Faac does not have mp4 support"
+               echo "WARNING: Encoding untagged files to aac..."
+               OUTPUTTYPE=aac
+       else
+               echo "Using Faac to Tag AAC Tracks..."
+       fi
 fi
 
 # And last but not least, check if we can diff between files. We do not abort,
@@ -4298,7 +4510,7 @@ fi
 
 if [ X"$CDSPEEDVALUE" != "X" ]; then
        case "$CDROMREADERSYNTAX" in
-               cdparanoia|debug) ;;
+               cdparanoia|libcdio|debug) ;;
                pird) ;;
                flac) ;;
                *) do_cdspeed ;;
@@ -4335,6 +4547,10 @@ if [ ! "$ONETRACK" = "y" ]; then
        fi
 fi
 
+if [ "$GETALBUMART" = "y" ]; then
+       do_getalbumart
+fi
+
 # For the lowdisk option, only one program is running at once so the encoder
 # can be unsilenced right away.
 if [ "$LOWDISK" = "y" ] || [ "$ONETRACK" = "y" ]; then